Fix up for Python 3.x #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two issues needed fixed. First spidev is not buffered so we need to open it as an unbuffered binary file. Second ctypes.string_at returns a bytes object instead of a str in python 3.x so we don't want to convert a str to an array of integers when returning from read and transfer, since we already have arrays of ints.
Author
|
Should probably bump version so PyPi and pip see this as an update. I didn't because it could be a minor or a micro depending on opinion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues needed fixed. First spidev is not buffered so we need to open
it as an unbuffered binary file. Second ctypes.string_at returns a bytes
object instead of a str in python 3.x so we don't want to convert a str
to an array of integers when returning from read and transfer, since we
already have arrays of ints.